Update caches on item creation #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not updating our local caches when items were created; this was not resulting in functional issues because of our cache-busting logic, but it was resulting in non-optimal caching and an increase in API calls as a result of being unable to rely on the cache. Specifically, rclone verifies files immediately after creation by checking their stats. This meant that every time a file was uploaded it would result in a preventable API call to `/folder/getWithChildren`. There were some circumstances where a similar unnecessary call could happen after folder creation. Issue #306 Update cache after file / folder creation
nfebe
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves our caching logic so that we update our local caches to reflect the state of permanent upon archive record and archive folder creation. In both cases this will prevent unnecessary call to the permanent back end.
I did verify locally that this lowers the number of calls to the API by 1 for each archive record being created.
Resolves #306