-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Drawable LineChart Fill Bug #5284
base: master
Are you sure you want to change the base?
Conversation
The LineChart fill draws using intervals to avoid memory issues, but with a larger data set and many different (darker) colors Android does not draw the drawable all the way to the edge of the interval. This makes it look like there are spaces between the fill. Draw a little beyond the existing interval so there are no gaps.
The LineChart fill draws using intervals to avoid memory issues, but with a larger data set and many different (darker) colors Android does not draw the drawable all the way to the edge of the interval. This makes it look like there are spaces between the fill. Draw a little beyond the existing interval so there are no gaps. PhilJay#5284
It's included here https://github.com/AppDevNext/MPAndroidChart/releases/tag/3.1.0.7 |
@hannesa2 There's actually an issue with this when the fill color isn't fully opaque so you probably want to remove that. |
What should I do ? If it's related to my fork, then let's continue there |
I really like this library and using it in my apps, I would like to call people to continue with this awesome thing. I have forked the repo and started working on it! So I am ready as well to accept pull requests, I'll notify other people from here as well! Code is full kotlin now! Make your pull requests here: |
Only do it for larger sets so we can still use opacity on smaller datasets.
PR Checklist:
PR Description
The LineChart fill draws using intervals to avoid
memory issues, but with a larger data set and many
different (darker) colors Android does not draw the
drawable all the way to the edge of the interval.
This makes it look like there are spaces between the fill.
Draw a little beyond the existing interval so there are no gaps.
Here is what it looks like before my change, look closely at the white vertical lines at ~1/5 ~3/5 ~4/5 of the way across the X-axis.
The same color with the fix no longer has gaps.