Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RoundedBarChartRenderer & RoundedHorizontalBarChartRenderer for Rounded corner Bar Chart #5420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

katara-mohini
Copy link

… corner radius positive/negative Bar Chart

PR Checklist:

  • [✓ ] I have tested this extensively and it does not break any existing behavior.
  • [✓ ] I have added/updated examples and tests for any new behavior.
  • [✓ ] If this is a significant change, an issue has already been created where the problem / solution was discussed: N/A

PR Description:

  1. Added RoundedBarChartRenderer for vertical Positive/Negative BarChart with customised rounded corners.
  2. RoundedHorizontalBarChartRenderer for horizontal BarChart with customised rounded corners.

Added Feature:

This PR is for BarChartRenderer and HorizontalBarChartRenderer customisation.

PR has to be merged:

So that users can customise BarChart corners according to their requirements.

… corner radius positive/negative Bar Chart
@Paget96
Copy link

Paget96 commented Jun 21, 2024

There is crash when we use FloatArray for Y values.

Crash happens here, as we don't have y, instead yVals

  if ((dataSet.getEntryForIndex(j / 4).y < 0 && roundedNegativeDataSetRadius > 0)) {

This is only needed to make it perfect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants