Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MFG Data fix on android #619

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

biii-anuj-pathak
Copy link

BLE Spec allows sending MFG data of more than 24 bytes by adding MFG data fields in the scan response packet, by default iOS concat it but android doesn't thus we manually concat mfg data spreaded across multiple packets

@Taym95
Copy link
Collaborator

Taym95 commented Nov 2, 2022

Thanks lot for contribution, I will make sure to review this week!

@Taym95
Copy link
Collaborator

Taym95 commented Dec 12, 2022

CI is failing

Append MFG data of Advertising and ScanResponse Packet.
By Spec Ble allows sending MFG data of more than 24 bytes by adding MFG data fields in the scan response packet, by default iOS concat it but android doesn't thus we manually concat mfg data spreaded across multiple packets
@biii-anuj-pathak
Copy link
Author

@Taym95
CI/CD passed after rebase, earlier it failed due to the XCode version requirement.
Ready for review

@nataddrho
Copy link

This issue is exactly where I am stuck. I developed a small sensor that sends proprietary data on both the advertisement and scan response packets. The advantage of doing this is that the sensor is transmit only and multiple observers can see the sensor simultaneously, a requirement.

Currently the scan response data over-writes the advertisement data, and all I see from the device is:

I/flutter ( 9444): DiscoveredDevice(id: EA:3B:31:D2:73:E8, name: , serviceData: {}, serviceUuids: [], manufacturerData: [222, 3, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], rssi: -71)

I should be seeing two arrays of this size.

Flutter Blue Plus has the same problem.

@biii-anuj-pathak
Copy link
Author

@Taym95 Any update on this?

@Taym95
Copy link
Collaborator

Taym95 commented Jan 17, 2024

@biii-anuj-pathak can you please rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants