Add message UUID and type names to hash and message defintion #1409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaDizzy
approved these changes
Sep 21, 2024
gerth2
force-pushed
the
serde-hashes
branch
from
7a8063f
to
0f87540
Compare
…checking, wpiformat
gerth2
approved these changes
Sep 23, 2024
|
Lit, thanks for the review and python tweaks Chris! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message hash is now calculated as the md5sum of the message type string. Arguably we should move away from YAML for our message definitions anyways so we don't have to convert back over from YAML to dict to type string, but then I'd actually need to parse typestrings in python. Which should happen at some point, but is out of scope here.