Initial Merge Pull Request #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewjrosen
suggested changes
Mar 29, 2017
Log_of_planck_function.py
Outdated
| # So logflux (which is what we want) is just the log of this | ||
| logflux[i] = logfactor + np.log10(flux[i]) | ||
| return logflux | ||
|
|
There was a problem hiding this comment.
You should comment on everything below. Explain more what is going on.
Spectral_Radiance.py
Outdated
| @@ -0,0 +1,54 @@ | |||
| from __future__ import print_function | |||
…ion from the MCMC calculation
…ons with an arbitrary and a calculated burn point
…esult int results.dat, Spectral_radiance uses results.dat to plot last estimate, spectral_radiance.py does the same with some issues
kelle
requested changes
Apr 13, 2017
.cache/v/cache/lastfailed
Outdated
| @@ -0,0 +1 @@ | |||
| {} | |||
There was a problem hiding this comment.
this file should not be tracked by github. (Nothing in the .cache directory should be.)
| @@ -0,0 +1,474 @@ | |||
| { | |||
There was a problem hiding this comment.
Pretty sure this file shouldn't be tracked either.
mcmc_test/Log_of_planck_function.py
Outdated
| flux=np.empty([len(wavelength)]) | ||
| logflux=np.empty([len(wavelength)]) | ||
| for i in range(len(wavelength)): | ||
| # Flux is just the Planck function |
mcmc_test/Log_of_planck_function.py
Outdated
| for i in range(len(wavelength)): | ||
| # Flux is just the Planck function | ||
| flux[i] = ( (2.0*con.h*con.c**2)/(wavelength[i]**5) )/( np.exp( (con.h*con.c)/(con.k*Teff*wavelength[i]) ) - 1.0 ) | ||
| # So logflux (which is what we want) is just the log of this |
There was a problem hiding this comment.
delete "just". logflux is the log of the Planck function.
mcmc_test/Log_of_planck_function.py
Outdated
|
|
||
| results = ascii.read("results.dat") | ||
|
|
||
| T1 = 100 |
mcmc_test/Log_of_planck_function.py
Outdated
| T3 = 300 | ||
| MCMC_Temp = results[0][0] | ||
|
|
||
| Y1_B = (np.log10(planck(X*10**-6,T1))) |
There was a problem hiding this comment.
I dont know what the code is doing here. what does Y1_B mean?
mcmc_test/Log_of_planck_function.py
Outdated
| Y4_B = (np.log10(planck(X*10**-6,T3))) | ||
|
|
||
|
|
||
| x = np.asarray([3.368,4.618,12.082,22.194,3.6,4.5]) |
There was a problem hiding this comment.
where do these numbers come from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.