Fixed & improvements for deleting all markers #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d deleteAllMarkers for all namespaces, added getters for marker ID's
JafarAbdi
requested changes
Jun 21, 2021
src/rviz_visual_tools.cpp
Outdated
Comment on lines
86
to
87
| visualization_msgs::msg::Marker delete_ns_marker = reset_marker_; | ||
| delete_ns_marker.header.stamp = builtin_interfaces::msg::Time(); |
There was a problem hiding this comment.
builtin_interfaces::msg::Time & visualization_msgs::msg::Marker are for ROS2 and which isn't the case on the master branch
There was a problem hiding this comment.
oops, good catch. should be fixed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same change made in PR #188, but for the master branch.