Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend EnumerableAssertHasSize* Refaster rules #1512

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Extend EnumerableAssertHasSize* Refaster rules #1512

wants to merge 2 commits into from
+96 −26

Conversation

rickie
Copy link
Member

@rickie rickie commented Jan 13, 2025 •
edited by mohamedsamehsalah
Loading

Suggested commit message:

Extend `EnumerableAssertHasSize*` Refaster rules (#1512)

By also matching on `.returnToIterable()`.

@rickie rickie requested a review from Stephan202 January 13, 2025 14:27
@rickie rickie added this to the 0.20.0 milestone Jan 13, 2025
@rickie rickie force-pushed the rossendrijver/assertj_return_iterable branch from 93a6276 to 5aa0832 Compare January 13, 2025 14:28
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

1 similar comment
@github-actions GitHub Actions
Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mohamedsamehsalah
mohamedsamehsalah approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedsamehsalah mohamedsamehsalah mohamedsamehsalah approved these changes

@Stephan202 Stephan202 Awaiting requested review from Stephan202

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
new feature
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rickie @mohamedsamehsalah