-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apps/prod/tekton/configs/tasks): update worked rustup mirror #1266
Conversation
builds failed in fetch the date nightly toolchain Signed-off-by: wuhuizuo <[email protected]>
Based on the pull request title and description, it seems that the changes are related to disabling the rustup mirror to fix build failures. The key changes in the diff are that the lines setting the rustup mirror have been commented out in three different YAML files. This change will disable the use of the mirror for rustup, which might result in slower downloads of Rust toolchain files. There are no new problems introduced by this pull request, but there is a potential problem with the change. If the original build failures were caused by slow downloads from the default Rustup server, disabling the mirror might make the problem worse. It is also possible that the mirror was not the cause of the build failures, and disabling it might not help. To fix this, it might be better to investigate the root cause of the build failures and address that instead of simply disabling the rustup mirror. If disabling the mirror is the best solution, it would be good to document the reason for this change and monitor the build times to ensure that there are no negative impacts. In summary, the pull request disables the rustup mirror to fix build failures, but it might not be the best solution. Investigating the root cause of the build failures is recommended, and if disabling the mirror is the best solution, it should be documented and monitored. |
Signed-off-by: wuhuizuo <[email protected]>
Based on the title and description, it seems that the PR intends to fix a build failure issue by disabling a rustup mirror. The diff shows that the PR modifies the Potential problems:
Fixing suggestions:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
builds failed in fetch the date nightly toolchain
Signed-off-by: wuhuizuo [email protected]