Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins-beta): correct nodeselector conf #658

Merged

Conversation

purelind
Copy link
Contributor

@purelind purelind commented Aug 1, 2023

correct nodeselector conf.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and wuhuizuo August 1, 2023 15:11
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, the key change in this PR is to correct the nodeselector configuration for the jenkins-beta application in the apps/prod directory. Specifically, the scheduler.alpha.kubernetes.io/node-selector field is updated to ci-nvme-high-performance=true. The scheduler.alpha.kubernetes.io/defaultTolerations field is also modified, but this does not seem to be the main focus of the PR.

As for potential problems, there are no obvious issues with the changes made in this PR. However, it would be helpful to have more context about the reasoning behind the change, such as why ci-nvme-high-performance was chosen as the node selector value and whether this change could impact any other applications.

In terms of fixing suggestions, the PR author may want to provide more details about the changes in the pull request description. Additionally, it would be helpful to have more information about the testing that was done to ensure that the updated configuration works as expected.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 32dd087 into PingCAP-QE:main Aug 1, 2023
3 checks passed
@purelind purelind deleted the purelind/fix-apps-jenkins-beta branch August 2, 2023 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant