Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts/jenkins/templates/test): bump image bats/bats to v1.10.0 #671

Merged
merged 2 commits into from
Sep 2, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 22, 2023

The 1.2.0 has no arm64 container image published, and the v1.10.0 has multi-arch image published.

Signed-off-by: wuhuizuo [email protected]

The `1.2.0` has no arm64 container image published, and the `1.10.0` has multi-arch image published.

Signed-off-by: wuhuizuo <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind August 22, 2023 07:04
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Summary:

The pull request is titled "fix(charts/jenkins/templates/test): bump image bats/bats to 1.10.0". It is updating the bats/bats Docker image version from 1.2.1 to 1.10.0 in the jenkins-test.yaml file located in the charts/jenkins/templates/tests directory. The reason for this change is that the 1.2.0 version does not have an arm64 container image published, while the 1.10.0 version has a multi-arch image published. The Chart.yaml file is also updated from version 4.1.21 to 4.1.22.

Potential Problems:

There are no potential problems in this pull request.

Fixing Suggestions:

No fixing suggestions are needed. The update seems to be straightforward and makes sense.

@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 22, 2023
@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Aug 22, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijie0123, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 22, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-22 07:20:54.907514948 +0000 UTC m=+1220419.456530920: ☑️ agreed by lijie0123.
  • 2023-09-02 08:35:00.375700607 +0000 UTC m=+2175264.924716594: ✖️🔁 reset by wuhuizuo.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

New changes are detected. LGTM label has been removed.

@wuhuizuo wuhuizuo added the lgtm label Sep 2, 2023
@wuhuizuo wuhuizuo changed the title fix(charts/jenkins/templates/test): bump image bats/bats to 1.10.0 fix(charts/jenkins/templates/test): bump image bats/bats to v1.10.0 Sep 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3708231 into main Sep 2, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/charts/jenkins/test branch September 2, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants