Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tibuild support dot in branch name #672

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: tibuild support dot in branch name #672

merged 1 commit into from
Aug 24, 2023

Conversation

jayl1e
Copy link
Contributor

@jayl1e jayl1e commented Aug 24, 2023

Why:

  • update tibuild to fix gitRef regex

@ti-chi-bot ti-chi-bot bot requested review from purelind and wuhuizuo August 24, 2023 11:12
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

This pull request fixes an issue with the tibuild process, which prevented it from correctly handling branch names containing dots. The proposed change updates the tibuild image to a new version (hub.pingcap.net/tibuild/tibuild:ba975d9) that includes a fix for the gitRef regex.

Potential Problems

The pull request looks good, but there are a few things to consider:

  • It's unclear what impact this change will have on the system, so it may be necessary to test the updated tibuild image to make sure everything still works as expected.
  • It's also unclear why the nodeSelector was added, and whether this change has been tested in the target environment.

Fixing Suggestions

  • If possible, test the updated tibuild image to ensure that it works correctly with branch names containing dots.
  • Add a comment to the pull request that explains the reasoning behind adding the nodeSelector, and whether it has been tested in the target environment.

@jayl1e
Copy link
Contributor Author

jayl1e commented Aug 24, 2023

/approve

@ti-chi-bot ti-chi-bot bot added the size/XS label Aug 24, 2023
Copy link
Contributor

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lijie0123, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 24, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 11:14:46.865022833 +0000 UTC m=+1407251.414038804: ☑️ agreed by purelind.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 24, 2023
@ti-chi-bot ti-chi-bot bot merged commit d61ee42 into main Aug 24, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix_branch branch August 24, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants