Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins-beta/release): fix plugin #696

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Oct 5, 2023

git plugin is the downstream plugin, it no need to declare it in plugin configuration.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind October 5, 2023 17:59
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the diff provided, it seems that this pull request removes the git plugin from the values-controller-plugins.yaml file in the apps/prod/jenkins-beta/release directory. It is not mentioned why this change is being made.

Potential problems:

  • Removing the git plugin may cause issues if it is being used by other parts of the application or if it is necessary for the proper functioning of the jenkins-beta application.
  • If the removal of the git plugin is intentional, it should be documented in the PR description.

Fixing suggestions:

  • If the git plugin is not necessary for the jenkins-beta application, the PR description should mention why it is being removed.
  • If the git plugin is necessary, it should not be removed and the PR should be closed.
  • If the git plugin is not necessary, but may be used by other parts of the application, it should be mentioned in the PR description and alternative solutions should be proposed.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Oct 5, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Oct 5, 2023

/review default

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

@wuhuizuo:

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the information provided, the pull request seems to remove the git plugin from the values-controller-plugins.yaml file.

The potential problem with this change is that removing the git plugin may break the functionality of the Jenkins pipeline if it depends on this plugin.

A possible suggestion is to make sure that the pipeline does not depend on the git plugin before removing it. If the pipeline does depend on it, the plugin should be kept.

Another suggestion is to update the documentation for the pipeline to reflect this change, so other developers are aware of it.

In response to this:

/review default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 88ccab9 into main Oct 5, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/apps-prod-jenkins-beta-plugins branch October 5, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant