Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UsdLux] [hdEmbree] Update documentation for UsdLux, and make hdEmbree provide a reference implementation #3200

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
37da07b
Add explanation of UsdLux quantities and behavior
anderslanglands Oct 24, 2023
a1d7d83
address review notes from @meshula
pmolodo Aug 4, 2024
2533cb0
address additional code notes from @meshula
pmolodo Aug 4, 2024
e493051
address code review notes from @anderslanglands
pmolodo Aug 4, 2024
e12942c
specifically mention desire to avoid unspecified uplight
pmolodo Aug 6, 2024
2bd74e3
re-ran usdGenSchema
pmolodo Aug 6, 2024
58058a8
[hdEmbree][build_usd] add to build_usd.py status message
pmolodo Aug 15, 2024
7341bf0
[work] fix docs for Work_NormalizeThreadCount
pmolodo Oct 22, 2024
89e974f
[hdEmbree] ensure we respect PXR_WORK_THREAD_LIMIT
pmolodo Jul 10, 2024
76c2135
[hdEmbree] Initial UsdLux reference implementation
anderslanglands Aug 31, 2023
6e232d7
[hdEmbree] add HDEMBREE_LIGHT_CREATE debug code
pmolodo Jul 29, 2024
035a0d1
[hdEmbree] add support for lighting double-sided meshes
pmolodo Jul 22, 2024
988665c
[hdEmbree] add support for inputs:diffuse
pmolodo Jul 31, 2024
ebb46db
[hdEmbree] add light texture support
pmolodo Jul 30, 2024
4cb4d2f
[hdEmbree] add dome light suppport
pmolodo Jul 30, 2024
bfd9507
[hdEmbree] add direct camera visibility support for rect lights
pmolodo Jul 30, 2024
64da5d0
[hdEmbree] add pxrPbrt/pbrUtils.h
pmolodo Jul 30, 2024
d2840eb
[hdEmbree] add distant light support
pmolodo Jul 30, 2024
1a044a1
[hdEmbree] ies.h / ies.cpp: add unaltered
pmolodo Apr 24, 2024
8a6e0ce
[hdEmbree] ies.h / ies.cpp: patch, and add pxr-IES.patch and README.md
pmolodo May 22, 2024
b1765a8
[hdEmbree] build ies.cpp
pmolodo Jun 5, 2024
e620064
[hdEmbree] ies: disable cycles' candela-to-watt conversion factor by
pmolodo Jun 5, 2024
85ebf2c
[hdEmbree] ies: add PxrIESFile subclass, which calculates power via i…
pmolodo Jun 6, 2024
fd70f4c
[hdEmbree] PxrIESFile: add eval() and valid() methods
anderslanglands May 21, 2024
cf4f1d3
[hdEmbree] add lighting support for IES files
pmolodo Jul 30, 2024
f36b3fa
Merge branch 'pr/usd-lux-update-ref-implementation' into pr/usd-lux-u…
pmolodo Oct 23, 2024
9b0c13b
Merge release v24.11
pixar-oss Oct 25, 2024
3349c7f
Merge tag 'v24.11' into pr/usd-lux-update
pmolodo Nov 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address additional code notes from @meshula
  • Loading branch information
pmolodo committed Aug 4, 2024
commit 2533cb0a9bbfed73a5e2c970c67d8b2f91a27b52
4 changes: 2 additions & 2 deletions pxr/usd/usdLux/generatedSchema.usda
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ class "LightAPI" (
radiance" or "tristimulus weight".

The emission of a default light with `intensity` 1 and `color` [1, 1, 1] is
an Illuminant D spectral power distribution with chromaticity matching the
an Illuminant D spectral distribution with chromaticity matching the
rendering color space white point, normalized such that a ray normally
incident upon the sensor with EV0 exposure settings will generate a pixel
value of [1, 1, 1] in the rendering color space.
@@ -162,7 +162,7 @@ class "LightAPI" (
remains constant while altering the size of the light, by dividing the
luminance by the world-space surface area of the light.

This makes it easier to independently adjust the power and shape
This makes it easier to independently adjust the brightness and size
of the light, by causing the total illumination provided by a light to
not vary with the area or angular size of the light.

4 changes: 2 additions & 2 deletions pxr/usd/usdLux/lightAPI.h
Original file line number Diff line number Diff line change
@@ -57,7 +57,7 @@ class SdfAssetPath;
/// radiance" or "tristimulus weight".
///
/// The emission of a default light with `intensity` 1 and `color` [1, 1, 1] is
/// an Illuminant D spectral power distribution with chromaticity matching the
/// an Illuminant D spectral distribution with chromaticity matching the
/// rendering color space white point, normalized such that a ray normally
/// incident upon the sensor with EV0 exposure settings will generate a pixel
/// value of [1, 1, 1] in the rendering color space.
@@ -425,7 +425,7 @@ class UsdLuxLightAPI : public UsdAPISchemaBase
/// remains constant while altering the size of the light, by dividing the
/// luminance by the world-space surface area of the light.
///
/// This makes it easier to independently adjust the power and shape
/// This makes it easier to independently adjust the brightness and size
/// of the light, by causing the total illumination provided by a light to
/// not vary with the area or angular size of the light.
///
8 changes: 4 additions & 4 deletions pxr/usd/usdLux/overview.dox
Original file line number Diff line number Diff line change
@@ -111,10 +111,10 @@ e.g. CIE 1931 𝓍̅. Thus the main quantity in an RGB renderer is neither radia
nor luminance, but "integrated radiance" or "tristimulus weight".

The emission of a default light with `intensity` 1 and `color` [1, 1, 1] is an
Illuminant D spectral power distribution with chromaticity matching the
rendering color space white point, normalized such that a ray normally incident
upon the sensor with EV0 exposure settings will generate a pixel value of [1, 1,
1] in the rendering color space.
Illuminant D spectral distribution with chromaticity matching the rendering
color space white point, normalized such that a ray normally incident upon the
sensor with EV0 exposure settings will generate a pixel value of [1, 1, 1] in
the rendering color space.

Given the above definition, that means that the luminance of said default light
will be 1 *nit (cd∕m²)* and its emission spectral radiance distribution is
4 changes: 2 additions & 2 deletions pxr/usd/usdLux/schema.usda
Original file line number Diff line number Diff line change
@@ -64,7 +64,7 @@ class "LightAPI" (
radiance" or "tristimulus weight".

The emission of a default light with `intensity` 1 and `color` [1, 1, 1] is
an Illuminant D spectral power distribution with chromaticity matching the
an Illuminant D spectral distribution with chromaticity matching the
rendering color space white point, normalized such that a ray normally
incident upon the sensor with EV0 exposure settings will generate a pixel
value of [1, 1, 1] in the rendering color space.
@@ -253,7 +253,7 @@ class "LightAPI" (
remains constant while altering the size of the light, by dividing the
luminance by the world-space surface area of the light.

This makes it easier to independently adjust the power and shape
This makes it easier to independently adjust the brightness and size
of the light, by causing the total illumination provided by a light to
not vary with the area or angular size of the light.