Fix guild cache when requesting guild through UUID or name and add support for PHP 8 #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…000 to get milliseconds, as required by the isExpired method
|
By the way @Plancke, don't forget to add the label 'hacktoberfest' to this repository for some Hacktoberfest goodness 😉 |
|
There are a couple more calls to that method in the Mongo handler as well, afaik all timestamps in cached data are seconds so those are probably also non-functioning. Though with how I check the existing guild's collection first before doing this byName/byPlayer lookup it's probably not impacted. |
|
Fair enough, I don't use that handler myself so I've missed that. I'll look into it later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
CacheUtil::isExpiredcompares timestamps in order to validate if a timestamp is older than allowed, defined by a given cache time. Both the timestamp and cache time should be in milliseconds, but are given in seconds, therefore always yieldingtrueas a result, breaking the caching mechanism. Additionally, support for PHP 8 is added in composer.json.