Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set bundle config as internal environment variables #1077

Merged
merged 2 commits into from
Sep 27, 2024
Merged

Set bundle config as internal environment variables #1077

merged 2 commits into from
Sep 27, 2024

Conversation

tbrockman
Copy link
Contributor

@tbrockman tbrockman commented Sep 18, 2024 •
edited
Loading

Details

So that variables like PLASMO_BROWSER are accessible in downstream Parcel plugins via process.env.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

Contacts

  • (OPTIONAL) Discord ID:

If your PR is accepted, we will award you with the Contributor role on Discord server.

To join the server, visit: https://www.plasmo.com/s/d

louisgv
louisgv approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv merged commit 2885b2e into PlasmoHQ:main Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louisgv louisgv louisgv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbrockman @louisgv