Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CSP Restriction for TrustedTypePolicy Creation in Loading Indicator #986

Merged
merged 1 commit into from
Jun 8, 2024
Merged

fix: CSP Restriction for TrustedTypePolicy Creation in Loading Indicator #986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion core/parcel-runtime/src/utils/loading-indicator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,27 @@

const LOADING_ID = "__plasmo-loading__"

// Function to update the CSP to allow the new trusted type policy
function updateCSP() {
const cspMetaTag = document.querySelector('meta[http-equiv="Content-Security-Policy"]')

if (!cspMetaTag) {
return true
}

const currentCSP = cspMetaTag.getAttribute('content')
const newPolicy = ` trusted-html-${LOADING_ID}`

if (!currentCSP.includes(newPolicy)) {
const updatedCSP = currentCSP + newPolicy
cspMetaTag.setAttribute('content', updatedCSP)
}

return true
Comment on lines +18 to +29
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The true returned here is mainly for the caller's control flow. It's a bit convoluted, but the tech debt seems localized to this module so we can deal with it later.

}

const trustedPolicy = typeof trustedTypes !== "undefined"
? trustedTypes
? updateCSP() && trustedTypes
.createPolicy(`trusted-html-${LOADING_ID}`, { createHTML: str => str })
: undefined

Expand Down
Loading