[update] add standard linter and fix warnings

main/index.js

@@ -8,7 +8,7 @@ const setIPCEvents = require('./ipc-events')
 
 const windows = []
 
-async function createWindow() {
+async function createWindow () {
   let win
   let server
 
@@ -30,8 +30,8 @@ async function createWindow() {
     show: false,
     webPreferences: {
       devTools: dev,
-      textAreasAreResizable: false,
-    },
+      textAreasAreResizable: false
+    }
   })
 
   windows.push(win)
@@ -78,8 +78,3 @@ app.on('activate', () => {
     createWindow()
   }
 })
-
-app.on('open-url', (event, string) => {
-  event.preventDefault()
-  fs.writeFileSync('~/test', 'utf8', string)
-})

main/ipc-events.js

@@ -6,7 +6,7 @@ module.exports = () => {
     const files = dialog.showOpenDialog({
       defaultPath: app.getPath('documents'),
       filters: [{ name: 'Markdown', extensions: ['md'] }],
-      properties: ['openFile'],
+      properties: ['openFile']
     })
 
     if (!files || files.length === 0) return
@@ -31,7 +31,7 @@ module.exports = () => {
       dialog.showSaveDialog({
         defaultPath: app.getPath('documents'),
         filters: [{ name: 'Markdown', extensions: ['md'] }, { name: 'All Files', extensions: ['*'] }],
-        showsTagField: false,
+        showsTagField: false
       })
 
     if (!fileName) return

main/menu.js

@@ -1,5 +1,4 @@
 const { app, Menu, shell } = require('electron')
-const dev = require('electron-is-dev')
 
 const template = [
   {
@@ -13,8 +12,8 @@ const template = [
       { role: 'paste' },
       { role: 'pasteandmatchstyle' },
       { role: 'delete' },
-      { role: 'selectall' },
-    ],
+      { role: 'selectall' }
+    ]
   },
   {
     label: 'View',
@@ -26,22 +25,22 @@ const template = [
       { role: 'zoomin' },
       { role: 'zoomout' },
       { type: 'separator' },
-      { role: 'togglefullscreen' },
-    ],
+      { role: 'togglefullscreen' }
+    ]
   },
   {
     role: 'window',
-    submenu: [{ role: 'minimize' }, { role: 'close' }],
+    submenu: [{ role: 'minimize' }, { role: 'close' }]
   },
   {
     role: 'help',
     submenu: [
       {
         label: 'Learn More',
-        click: () => shell.openExternal('https://platzi.com'),
-      },
-    ],
-  },
+        click: () => shell.openExternal('https://platzi.com')
+      }
+    ]
+  }
 ]
 
 if (process.platform === 'darwin') {
@@ -56,16 +55,16 @@ if (process.platform === 'darwin') {
       { role: 'hideothers' },
       { role: 'unhide' },
       { type: 'separator' },
-      { role: 'quit' },
-    ],
+      { role: 'quit' }
+    ]
   })
 
   // Edit menu
   template[1].submenu.push(
     { type: 'separator' },
     {
       label: 'Speech',
-      submenu: [{ role: 'startspeaking' }, { role: 'stopspeaking' }],
+      submenu: [{ role: 'startspeaking' }, { role: 'stopspeaking' }]
     }
   )
 
@@ -75,7 +74,7 @@ if (process.platform === 'darwin') {
     { role: 'minimize' },
     { role: 'zoom' },
     { type: 'separator' },
-    { role: 'front' },
+    { role: 'front' }
   ]
 }
 

main/server.js

@@ -1,6 +1,5 @@
 const { app } = require('electron')
 const { createServer } = require('http')
-const next = require('next')
 
 const dev = require('electron-is-dev')
 

package.json

@@ -14,7 +14,19 @@
     "prepack": "npm run clean",
     "predist": "npm run clean",
     "pack": "npm run build && build --dir",
-    "dist": "npm run build && build"
+    "dist": "npm run build && build",
+    "lint": "standard 'main/*.js' 'renderer/**/*.js'",
+    "precommit": "lint-staged"
+  },
+  "standard": {
+    "parser": "babel-eslint",
+    "ignore": [
+      "**/node_modules/**",
+      "**/.next/**"
+    ]
+  },
+  "lint-staged": {
+    "*.js": "standard"
   },
   "build": {
     "appId": "co.platzi.pulse",
@@ -62,8 +74,11 @@
     "react-icons": "^2.2.5"
   },
   "devDependencies": {
+    "babel-eslint": "^7.2.3",
     "babili-webpack-plugin": "^0.0.11",
     "electron": "^1.6.8",
-    "electron-builder": "^17.8.0"
+    "electron-builder": "^17.8.0",
+    "lint-staged": "^3.4.2",
+    "standard": "^10.0.2"
   }
 }

renderer/components/new-button.js

@@ -1,6 +1,6 @@
 import { Component } from 'react'
 import { Base } from 'pulse-editor/buttons'
-import { string, func } from 'prop-types'
+import { func } from 'prop-types'
 import isMac from 'pulse-editor/built/utils/is-mac'
 import Icon from 'react-icons/lib/fa/file-o'
 
@@ -9,10 +9,10 @@ export default class NewButton extends Component {
     setShortcut: func.isRequired,
     setFileName: func.isRequired,
     removeShortcut: func.isRequired,
-    writeValue: func.isRequired,
+    writeValue: func.isRequired
   }
 
-  componentDidMount() {
+  componentDidMount () {
     this.context.setShortcut({
       ctrlKey: !isMac(),
       metaKey: isMac(),
@@ -23,11 +23,11 @@ export default class NewButton extends Component {
       handler: event => {
         this.createFile()
         return event.selection
-      },
+      }
     })
   }
 
-  componentWillUnmount() {
+  componentWillUnmount () {
     this.context.removeShortcut({ keyName: 'o' })
   }
 
@@ -39,8 +39,8 @@ export default class NewButton extends Component {
   handleClick = () => this.createFile()
 
   render = () => (
-    <Base onClick={this.handleClick} name="new">
-      <span title="New file [CMD+N]">
+    <Base onClick={this.handleClick} name='new'>
+      <span title='New file [CMD+N]'>
         <Icon /> New file
       </span>
     </Base>

renderer/components/open-button.js

@@ -1,7 +1,7 @@
 import { Component } from 'react'
 import { Base } from 'pulse-editor/buttons'
 import { ipcRenderer } from 'electron'
-import { string, func } from 'prop-types'
+import { func } from 'prop-types'
 import isMac from 'pulse-editor/built/utils/is-mac'
 import Icon from 'react-icons/lib/fa/folder-open-o'
 
@@ -10,10 +10,10 @@ export default class OpenButton extends Component {
     setShortcut: func.isRequired,
     removeShortcut: func.isRequired,
     writeValue: func.isRequired,
-    setFileName: func.isRequired,
+    setFileName: func.isRequired
   }
 
-  componentDidMount() {
+  componentDidMount () {
     ipcRenderer.on('file-opened', this.handleOpen)
     this.context.setShortcut({
       ctrlKey: !isMac(),
@@ -25,11 +25,11 @@ export default class OpenButton extends Component {
       handler: event => {
         this.openFile()
         return event.selection
-      },
+      }
     })
   }
 
-  componentWillUnmount() {
+  componentWillUnmount () {
     this.context.removeShortcut({ keyName: 'o' })
     ipcRenderer.removeListener('file-opened', this.handleOpen)
   }
@@ -44,8 +44,8 @@ export default class OpenButton extends Component {
   }
 
   render = () => (
-    <Base onClick={this.handleClick} name="open">
-      <span title="Open file [CMD+O]">
+    <Base onClick={this.handleClick} name='open'>
+      <span title='Open file [CMD+O]'>
         <Icon /> Open file
       </span>
     </Base>

renderer/components/save-button.js

@@ -1,7 +1,7 @@
 import { Component } from 'react'
 import { Base } from 'pulse-editor/buttons'
 import { ipcRenderer } from 'electron'
-import { string, func, bool } from 'prop-types'
+import { string, func } from 'prop-types'
 import isMac from 'pulse-editor/built/utils/is-mac'
 import Icon from 'react-icons/lib/fa/floppy-o'
 
@@ -11,10 +11,10 @@ export default class SaveButton extends Component {
     value: string.isRequired,
     setShortcut: func.isRequired,
     removeShortcut: func.isRequired,
-    setFileName: func.isRequired,
+    setFileName: func.isRequired
   }
 
-  componentDidMount() {
+  componentDidMount () {
     ipcRenderer.on('file-saved', this.handleSaved)
     this.context.setShortcut({
       ctrlKey: !isMac(),
@@ -26,11 +26,11 @@ export default class SaveButton extends Component {
       handler: event => {
         this.saveFile()
         return event.selection
-      },
+      }
     })
   }
 
-  componentWillUnmount() {
+  componentWillUnmount () {
     ipcRenderer.removeListener('file-saved', this.handleSaved)
     this.context.removeShortcut({ keyName: 's' })
   }
@@ -46,8 +46,8 @@ export default class SaveButton extends Component {
   }
 
   render = () => (
-    <Base onClick={this.handleClick} name="save">
-      <span title="Save file [CMD+S]">
+    <Base onClick={this.handleClick} name='save'>
+      <span title='Save file [CMD+S]'>
         <Icon /> Save file
       </span>
     </Base>

renderer/next.config.js

@@ -1,7 +1,7 @@
 const BabiliPlugin = require('babili-webpack-plugin')
 
 module.exports = {
-  webpack(config, { dev }) {
+  webpack (config, { dev }) {
     config.target = 'electron-renderer'
 
     config.plugins = config.plugins.filter(plugin => {
@@ -14,10 +14,10 @@ module.exports = {
 
     return config
   },
-  exportPathMap() {
+  exportPathMap () {
     return {
-      '/': { page: '/' },
+      '/': { page: '/' }
     }
   },
-  assetPrefix: './',
+  assetPrefix: './'
 }

renderer/pages/_document.js

@@ -2,13 +2,13 @@ import Document, { Head, Main, NextScript } from 'next/document'
 import flush from 'styled-jsx/server'
 
 export default class extends Document {
-  static getInitialProps({ renderPage }) {
+  static getInitialProps ({ renderPage }) {
     const { html, head, errorHtml, chunks } = renderPage()
     const styles = flush()
     return { html, head, errorHtml, chunks, styles }
   }
 
-  render() {
+  render () {
     return (
       <html>
         <Head>