Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PNatural #791

Merged
merged 9 commits into from
Jan 7, 2025
Merged

PNatural #791

merged 9 commits into from
Jan 7, 2025

Conversation

kozross
Copy link
Contributor

@kozross kozross commented Dec 18, 2024

Adds PNatural, as well as some support in type class operations. I haven't modified any existing functions to use it, although in many cases (such as indexing), we definitely should. Will save that for another PR.

@kozross kozross requested a review from t4ccer December 18, 2024 21:53
t4ccer
t4ccer reviewed Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@t4ccer t4ccer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally correct, but would be good to cut down on using punsafeCoerce in internal code, found a few places but there's probably a bit more

Plutarch/Internal/Numeric.hs Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
Plutarch/Internal/Numeric.hs Outdated Show resolved Hide resolved
@kozross kozross requested a review from t4ccer December 19, 2024 20:21
t4ccer
t4ccer previously approved these changes Dec 20, 2024
View reviewed changes
@kozross kozross requested a review from SeungheonOh January 6, 2025 21:29
@kozross kozross requested review from t4ccer and SeungheonOh January 7, 2025 00:53
SeungheonOh
SeungheonOh approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@SeungheonOh SeungheonOh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SeungheonOh SeungheonOh merged commit 1a30d9b into staging Jan 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeungheonOh SeungheonOh SeungheonOh approved these changes

@t4ccer t4ccer Awaiting requested review from t4ccer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kozross @SeungheonOh @t4ccer