Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor match #12

Merged
merged 4 commits into from
Aug 13, 2024
Merged

Refactor match #12

merged 4 commits into from
Aug 13, 2024

Conversation

louonezime
Copy link
Collaborator

@louonezime louonezime commented Aug 8, 2024 •
edited
Loading

Description

Please provide a detailed description of what was done in this PR.
Precise the issue that you are resolving.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functional / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@louonezime
refactor(matcher): adapt to parsing of cli for matching criteria
cbb4718 
simple immigration of models and use of multiple structs
@louonezime louonezime changed the base branch from main to connect-match-reqs August 8, 2024 18:15
@louonezime louonezime linked an issue Aug 8, 2024 that may be closed by this pull request
[Feature]: Clean the code #11
Closed
@louonezime louonezime self-assigned this Aug 8, 2024
@louonezime louonezime added this to the matching milestone Aug 8, 2024
pierrelissope
pierrelissope reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@pierrelissope pierrelissope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@pierrelissope pierrelissope merged commit 9ddafb7 into connect-match-reqs Aug 13, 2024
1 check passed
@pierrelissope pierrelissope deleted the refactor-match branch August 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrelissope pierrelissope pierrelissope left review comments

@SIMLUKE SIMLUKE Awaiting requested review from SIMLUKE

Assignees

@louonezime louonezime

Labels
architecture cli match
Projects
None yet
Milestone
matching
Development

Successfully merging this pull request may close these issues.

[Feature]: Clean the code
2 participants
@louonezime @pierrelissope