Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gustave/request to Connect to Init-Matching adapted #5

Merged
merged 11 commits into from
Jul 17, 2024
Merged

Gustave/request to Connect to Init-Matching adapted #5

merged 11 commits into from
Jul 17, 2024

Conversation

louonezime
Copy link
Collaborator

@louonezime louonezime commented Jul 16, 2024 •
edited
Loading

Description

Please provide a detailed description of what was done in this PR.
Precise the issue that you are resolving.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functional / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@louonezime louonezime closed this Jul 16, 2024
@louonezime louonezime reopened this Jul 16, 2024
@louonezime louonezime added match feature request make the request depending of the input architecture labels Jul 16, 2024
@louonezime louonezime added this to the matching milestone Jul 16, 2024
@louonezime louonezime changed the title Gustave/request to Connect to Init-Matching Gustave/request to Connect to Init-Matching adapted Jul 16, 2024
@57ave 57ave merged commit 2e47a15 into connect-match-reqs Jul 17, 2024
3 checks passed
@pierrelissope pierrelissope deleted the gustave/request branch August 8, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdeziri adamdeziri Awaiting requested review from adamdeziri

Assignees

@louonezime louonezime

@57ave 57ave

Labels
architecture feature match request make the request depending of the input
Projects
None yet
Milestone
matching
Development

Successfully merging this pull request may close these issues.
2 participants
@louonezime @57ave