Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cli arguments handling #7

Merged
merged 5 commits into from
Aug 8, 2024
Merged

feat: cli arguments handling #7

merged 5 commits into from
Aug 8, 2024

Conversation

SIMLUKE
Copy link
Collaborator

@SIMLUKE SIMLUKE commented Jul 22, 2024 •
edited
Loading

Description

Integration of clean cli for bruteforce

Changes include

  • New feature : clean cli
  • Breaking change : changes main function

Breaking changes

Changes main function

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functional / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@SIMLUKE SIMLUKE self-assigned this Jul 24, 2024
@SIMLUKE SIMLUKE requested a review from adamdeziri July 25, 2024 12:27
@SIMLUKE
Merge branch 'cli-interface' into test-temp-for-pr
372f7cf 
fixed conflicts and integrated new cli into existing bruteforcer
@SIMLUKE
fix: updated autocompletion files
ac340dc
@SIMLUKE SIMLUKE requested review from louonezime and 57ave July 30, 2024 17:49
@SIMLUKE SIMLUKE requested a review from 57ave August 8, 2024 16:11
57ave
57ave approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@57ave 57ave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem right

@SIMLUKE SIMLUKE merged commit 3d17afe into connect-match-reqs Aug 8, 2024
1 check passed
@pierrelissope pierrelissope deleted the cli-interface branch August 8, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@57ave 57ave 57ave approved these changes

@louonezime louonezime louonezime approved these changes

@adamdeziri adamdeziri Awaiting requested review from adamdeziri

Assignees

@SIMLUKE SIMLUKE

Labels
architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SIMLUKE @louonezime @57ave