Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Ads): add AdsStore #1007

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from
Draft

feat(Ads): add AdsStore #1007

wants to merge 6 commits into from

Conversation

Gio2018
Copy link
Collaborator

@Gio2018 Gio2018 commented May 15, 2024

Summary

  • Include short description of what this PR accomplishes

References

  • Links to docs, tickets, designs if available

Implementation Details

  • Overview of work that was implemented and changes made to the codebase

Test Steps

  • Write out what QA should do to verify this change works as expected and hasn't introduced regressions. Can mention specific OS versions, devices, areas of the app to test as needed.

PR Checklist:

  • Added Unit / UI tests
  • Self Review (review, clean up, documentation, run tests)
  • Basic Self QA

Screenshots

@pocket-ci
Copy link
Contributor

pocket-ci commented May 15, 2024

Messages
📖 No SwiftLint violations! 🎉
📖 Project coverage: 36.69%
📖 Checking XCode Environment Variables
📖 Edited 2 files
📖 Created 2 files

PocketKit: Coverage: 60.88

File Coverage
HomeViewModel.swift 64.67%
AdsStore.swift 24.14% ⚠️
HomeViewController.swift 61.35%
AdCarouselCellConfiguration.swift 92.68%

PocketKitTests: Coverage: 28.46

File Coverage
HomeViewModel.swift 42.39% ⚠️
AdsStore.swift 24.14% ⚠️
HomeViewController.swift 46.51% ⚠️
AdCarouselCellConfiguration.swift 0.0% ⚠️

Generated by 🚫 Danger Swift against bd40d50

@Gio2018 Gio2018 force-pushed the feat/POCKET-10116-ads-model branch 3 times, most recently from 97160d0 to bd40d50 Compare May 23, 2024 17:38
@Gio2018 Gio2018 force-pushed the feat/POCKET-10116-ads-model branch from bd40d50 to 06e70d4 Compare May 30, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants