Enable complete concurrency on PocketKit #2 #1021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Analytics: Coverage: 59.31
PocketKit: Coverage: 62.72
SharedPocketKit: Coverage: 62.45
Sync: Coverage: 71.93
SyncTests: Coverage: 22.69
SharedPocketKitTests: Coverage: 28.09
ItemWidgets.appex: Coverage: 0.0
AnalyticsTests: Coverage: 24.68
PocketKitTests: Coverage: 28.15
Generated by 🚫 Danger Swift against 377739c |
Gio2018
force-pushed
the
feat/POCKET-10202-pocketkit-concurrency-2
branch
3 times, most recently
from
6f89992
to
91e696f
Compare
Gio2018
force-pushed
the
feat/POCKET-10202-pocketkit-concurrency-2
branch
2 times, most recently
from
c44ae0b
to
9604d43
Compare
Gio2018
force-pushed
the
feat/POCKET-10202-pocketkit-concurrency-2
branch
4 times, most recently
from
c6c0c1a
to
af326bd
Compare
Gio2018
force-pushed
the
feat/POCKET-10202-pocketkit-concurrency-2
branch
5 times, most recently
from
189dee2
to
05f1663
Compare
Gio2018
force-pushed
the
feat/POCKET-10202-pocketkit-concurrency-2
branch
8 times, most recently
from
13aa37a
to
7bc3186
Compare
Gio2018
force-pushed
the
feat/POCKET-10202-pocketkit-concurrency-2
branch
4 times, most recently
from
43e3090
to
546a81d
Compare
…te to WKWebViewDelegate methods, and isolate mutable actions
… ProcessInfo.processInfo since the latter is immutable and concurrency safe
…dLine with ProcessInfo.processInfo since the latter is immutable and concurrency safe
…with ProcessInfo.processInfo since the latter is immutable and concurrency safe
…formance to closure in method perfomrExpiringActivity to match ProcessInfo v
…od completeRequest with NSExtensionContext
…tchSavedItemDetails (compared to fetchDetails) where we don't pass the Core Data entity
…temDetails method
…s implementations conform to Sendable
…licit @unchecked Sendable conformance
…from fetchDetailsIfNeeded()
…asically the Sendable version of ItemAction * The goal is to incrementally conform to Sendable in the various view models. * Update CollectionViewModel to use SendableItemAction * Update CollectionViewModel, publish url values to report an item or a story instead of the Core Data objects
… in CollectionViewodel
…publish Core Data entities Also remove the Report action from collection stories
… retroactive to build on the CI Also remove the Report action from collection stories
…mments Also remove the Report action from collection stories
…ate call concurrency safe
Gio2018
force-pushed
the
feat/POCKET-10202-pocketkit-concurrency-2
branch
from
bf4bf98
to
377739c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Test Steps