Skip to content

Commit

Permalink
remove deprecated use of pkg_resources, switch to importlib
Browse files Browse the repository at this point in the history
  • Loading branch information
timkpaine committed Feb 7, 2024
1 parent 21321b4 commit 38eb386
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 11 deletions.
6 changes: 3 additions & 3 deletions csp/adapters/db.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
from backports import zoneinfo

import pytz
from importlib.metadata import PackageNotFoundError, version as get_package_version
from packaging import version
from pkg_resources import DistributionNotFound, get_distribution

from csp import PushMode, ts
from csp.impl.adaptermanager import AdapterManagerImpl, ManagedSimInputAdapter
Expand All @@ -19,15 +19,15 @@
UTC = zoneinfo.ZoneInfo("UTC")

try:
if version.parse(get_distribution("sqlalchemy").version) >= version.parse("2"):
if version.parse(get_package_version("sqlalchemy")) >= version.parse("2"):
_SQLALCHEMY_2 = True
else:
_SQLALCHEMY_2 = False

import sqlalchemy as db

_HAS_SQLALCHEMY = True
except (DistributionNotFound, ValueError, TypeError, ImportError):
except (PackageNotFoundError, ValueError, TypeError, ImportError):
_HAS_SQLALCHEMY = False
db = None

Expand Down
13 changes: 8 additions & 5 deletions csp/adapters/output_adapters/parquet.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import numpy
import os
import pkg_resources
from importlib.metadata import PackageNotFoundError, version as get_package_version
from packaging import version
from typing import Callable, Dict, Optional, TypeVar

Expand Down Expand Up @@ -37,10 +37,13 @@ def resolve_compression(self):


def _get_default_parquet_version():
if version.parse(pkg_resources.get_distribution("pyarrow").version) >= version.parse("6.0.1"):
return "2.6"
else:
return "2.0"
try:
if version.parse(get_package_version("pyarrow")) >= version.parse("6.0.1"):
return "2.6"
except PackageNotFoundError:
# Don't need to do anything in particular
...
return "2.0"


class ParquetWriter:
Expand Down
6 changes: 3 additions & 3 deletions csp/adapters/parquet.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import datetime
import io
import numpy
import pkg_resources
import platform
import pyarrow
import pyarrow.parquet
from importlib.metadata import PackageNotFoundError, version as get_package_version
from packaging import version
from typing import TypeVar

Expand All @@ -28,9 +28,9 @@

try:
_CAN_READ_ARROW_BINARY = False
if version.parse(pkg_resources.get_distribution("pyarrow").version) >= version.parse("4.0.1"):
if version.parse(get_package_version("pyarrow")) >= version.parse("4.0.1"):
_CAN_READ_ARROW_BINARY = True
except (ValueError, TypeError):
except (PackageNotFoundError, ValueError, TypeError):
# Cannot read binary arrow
...

Expand Down

0 comments on commit 38eb386

Please sign in to comment.