Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CSP to Perspective 3.x #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sinistersnare
Copy link

Hi I'm Davis! I work at @ProspectiveCo, we maintain Perspective. We have been working alongside some people at Cubist (@ptomecek) and we are interested in upgrading CSP to use the new Perspective 3.0 API. Overall, the transition was quite simple, having to make some API changes around Table creation. The most issues were found in the pandas_perspective adapter, which seems deprecated in favor of the perspective adapter. I would like to remove it completely, but left it here for your review.

Specific modifications done to CSP for this change:

  • csp/dataframe.py: The to_perspective function now must take a Client object to construct the Table.
  • csp/adapters/perspective.py: The use of PerspectiveManager was changed to use of the new Client/Server classes.
  • csp/impl/pandas_perspective.py: Perspective Table JSON update does not support direct date or datetime values now, as theses are not JSON serializable types. To work around this, the objects are directly translated to timestamp integers and sent to Perspective to be parsed into Perspective’s time types. to_df was rewritten to route through PyArrow, but due to differences in how PyArrow chooses dtypes, there is some hackery around ordering of categories. We also removed to_dict and to_numpy because they were removed in the Perspective 3.0 migration.
  • csp/tests/impl/test_pandas_perspective.py many tests were fixed to demonstrate changes that are needed to continue day-to-day use of CspPerspectiveTable. Some tests were not fixed due to an outstanding Perspective bug (Unit test describing index behavior bug finos/perspective#2756).

The use of PyArrow to underly Perspective’s DataFrame support leads to some semantic changes. PyArrow is much more eager to set columns to CategoricalDtype instead of StringDtype. It also has different behavior regarding category ordering, and perhaps others still not uncovered after fixing the tests.

Let me know where you want to go with this!

Signed-off-by: Davis Silverman <[email protected]>
@ptomecek
Copy link
Collaborator

ptomecek commented Oct 7, 2024

Thanks for the PR!
Our plan was actually to move all perspective dependencies to a separate package (i.e. see #309).
However, we still have some work to do internally to support perspective 3, but we are actively working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants