-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dynamic endpoints to WebsocketAdapter #378
Open
NeejWeej
wants to merge
11
commits into
main
Choose a base branch
from
nk/websocket_dynamic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
2 times, most recently
from
November 3, 2024 22:25
3ed3981
to
2022cc9
Compare
NeejWeej
changed the title
[WIP] Add dynamic endpoints to WebsocketAdapter
[WIP] Add dynamic endpoints to WebsocketAdapter [#277]
Nov 3, 2024
NeejWeej
changed the title
[WIP] Add dynamic endpoints to WebsocketAdapter [#277]
[WIP] Add dynamic endpoints to WebsocketAdapter #277
Nov 3, 2024
NeejWeej
changed the title
[WIP] Add dynamic endpoints to WebsocketAdapter #277
[WIP] Add dynamic endpoints to WebsocketAdapter
Nov 3, 2024
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 13, 2024 15:44
fb9fdaa
to
a3447ec
Compare
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 25, 2024 06:11
c925d63
to
fcea900
Compare
NeejWeej
requested review from
robambalu,
AdamGlustein,
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
November 25, 2024 07:45
NeejWeej
changed the title
[WIP] Add dynamic endpoints to WebsocketAdapter
Add dynamic endpoints to WebsocketAdapter
Nov 25, 2024
Signed-off-by: Nijat K <[email protected]>
timkpaine
reviewed
Nov 25, 2024
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
5 times, most recently
from
November 26, 2024 08:01
f1af757
to
c98eef3
Compare
Signed-off-by: Nijat K <[email protected]>
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
2 times, most recently
from
November 29, 2024 03:31
a91f650
to
c6457bd
Compare
NeejWeej
commented
Nov 29, 2024
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 29, 2024 03:49
c6457bd
to
29db774
Compare
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 29, 2024 05:18
29db774
to
4d64618
Compare
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
November 29, 2024 06:36
4d64618
to
639c5aa
Compare
robambalu
reviewed
Nov 29, 2024
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
December 3, 2024 22:48
e7b2131
to
dbb1bb4
Compare
Signed-off-by: Nijat K <[email protected]>
NeejWeej
force-pushed
the
nk/websocket_dynamic
branch
from
December 3, 2024 23:10
dbb1bb4
to
8ca822c
Compare
timkpaine
added
type: enhancement
Issues and PRs related to improvements to existing features
adapter: websocket
Issues and PRs related to our websocket adapter
labels
Dec 4, 2024
wrieg123
reviewed
Dec 4, 2024
wrieg123
reviewed
Dec 4, 2024
wrieg123
reviewed
Dec 8, 2024
wrieg123
reviewed
Dec 8, 2024
wrieg123
reviewed
Dec 8, 2024
wrieg123
previously approved these changes
Dec 8, 2024
Signed-off-by: Nijat K <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
adapter: websocket
Issues and PRs related to our websocket adapter
type: enhancement
Issues and PRs related to improvements to existing features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
We basically have bi-directional maps from each adapter (subscribe/send) to the endpoints we have.