Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow job to automate uploading to testpypi #54

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

ngoldbaum
Copy link
Collaborator

Not sure how to make ASCII art matching the other jobs

@ngoldbaum ngoldbaum force-pushed the automate-testpypi-release branch 6 times, most recently from 7bbd97c to 67f519b Compare February 8, 2024 18:21
@timkpaine
Copy link
Member

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@ngoldbaum
Copy link
Collaborator Author

The other issue is that right now the version is static so testpypi won't let us upload a new release with every merged PR. I think scikit-build can work with setuptools_scm - did you ever look at that or any other kind of dynamic version generation from VCS versions?

@ngoldbaum
Copy link
Collaborator Author

For now just set it to only upload if a tag is added.

@ngoldbaum ngoldbaum marked this pull request as ready for review February 8, 2024 18:53
@timkpaine timkpaine self-assigned this Feb 8, 2024
@timkpaine timkpaine added tag: internal Issues and PRs for maintainance of the project - not interesting to external users part: distribution Issues and PRs related to distribution, e.g. pypa and conda labels Feb 10, 2024
@timkpaine
Copy link
Member

Can you make a tag like deleteme and push to your fork, and show the successful run just to verify

@ngoldbaum ngoldbaum force-pushed the automate-testpypi-release branch 4 times, most recently from a96125f to 9bf0c5a Compare February 13, 2024 00:08
@ngoldbaum
Copy link
Collaborator Author

Thanks for the suggestion to try on my fork. The way I originally configured it there were some bugs. Also I got tripped up on the check for tags that start with v so deleteme doesn't work but vdeleteme does.

Here's the action run https://github.com/ngoldbaum/csp/actions/runs/7879281136/job/21501011776

It failed to upload because my fork isn't a trusted publisher to testpypi for the csp pacakge. Would you like me to temporarily add it to make sure the upload goes through? We can also merge this as-is and debug once we push an e.g. v0.1.0 tag to the main repo.

trallard
trallard previously approved these changes Feb 14, 2024
Copy link
Collaborator

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me so I will go ahead and approve @ngoldbaum.
That way we can test the release and iterate as needed

@ngoldbaum ngoldbaum dismissed trallard’s stale review February 14, 2024 18:37

The merge-base changed after approval.

trallard
trallard previously approved these changes Feb 14, 2024
@ngoldbaum ngoldbaum dismissed trallard’s stale review February 14, 2024 18:42

The merge-base changed after approval.

timkpaine
timkpaine previously approved these changes Feb 14, 2024
@ngoldbaum ngoldbaum dismissed timkpaine’s stale review February 14, 2024 21:59

The merge-base changed after approval.

@ngoldbaum
Copy link
Collaborator Author

It's not clear to me why github is saying I'm dismissing stale reviews, it seems to be happening automatically.

@ngoldbaum
Copy link
Collaborator Author

I rebased again, I think if one of you approve it will be mergeable.

@ngoldbaum ngoldbaum merged commit 682e039 into Point72:main Feb 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: distribution Issues and PRs related to distribution, e.g. pypa and conda tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants