-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix freeze in hdl_grabber.cpp #5826
Fix freeze in hdl_grabber.cpp #5826
Conversation
Close the udp socket before stopping HDLGrabber. Tested only on Windows.
7536ace
to
c7e3d24
Compare
@SunlayGGX Hi, thanks for this PR. It would be great if we could fix this for all systems, not only windows. I looked into the Boost documentation, which says that I am also wondering: shouldn't the part after the catch block ( Unfortunately, I don't have a velodyne device for proper testing ... |
@mvieth Hi, thanks for reviewing my PR. You're right about using boost error code, I'll change that. Though it's not For the second part of your review, let's do it like you proposed because the result is the same ( Finally, you don't need a Velodyne to test. As said in the issue #4460, before the fix : the freeze happens when you cannot connect to one (either it isn't seen on the network, or it doesn't exist) and try to close the grabber. |
@SunlayGGX I tested with Ubuntu, no Velodyne device connected, and only calling
Yes please, that sounds good |
b50fc15
to
7f13704
Compare
Address PR comments to fix HDLGrabber freeze on Windows and Linux.
7f13704
to
8835fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, now the freeze is fixed on Linux, too 👍
Thank you so much for your review @mvieth . |
Sorry about the delay 😄 |
Close the udp socket before stopping HDLGrabber. Fix only for Windows.
Linked to issue #4460