Preparation for hidden visibility on gcc #6071
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In voxel_grid_label.cpp, the implementation of
VoxelGrid
(from voxel_grid.hpp) must be hidden, otherwiseVoxelGrid
is instantiated again, but with the wrong visibility attributes (would overwrite the correct instantiation fromvoxel_grid.cpp
). Same thing in sac_model_normal_plane.hpp: the implementation ofSampleConsensusModelPlane
must be hidden. The implementations ofdist8
anddist4
are moved from sac_model_plane.hpp to sac_model_plane.h so that they are available whenSampleConsensusModelNormalPlane
is instantiated and the compiler can optimize.Split off from #5779