Preparation for hidden visibility on gcc #6071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
reviewed
Jun 25, 2024
In voxel_grid_label.cpp, the implementation of `VoxelGrid` (from voxel_grid.hpp) must not be available, otherwise `VoxelGrid` is instantiated again, but with the wrong visibility attributes (would overwrite the correct instantiation from `voxel_grid.cpp`). Same thing in sac_model_normal_plane.hpp: the implementation of `SampleConsensusModelPlane` must not be available. The implementations of `dist8` and `dist4` are moved from sac_model_plane.hpp to sac_model_plane.h so that they are available when `SampleConsensusModelNormalPlane` is instantiated and the compiler can optimize.
mvieth
force-pushed
the
gcc_hidden_visibility3
branch
from
d1d10c8
to
d5c1a97
Compare
mvieth
added
the
changelog: enhancement
larshg
approved these changes
Jul 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In voxel_grid_label.cpp, the implementation of
VoxelGrid(from voxel_grid.hpp) must be hidden, otherwiseVoxelGridis instantiated again, but with the wrong visibility attributes (would overwrite the correct instantiation fromvoxel_grid.cpp). Same thing in sac_model_normal_plane.hpp: the implementation ofSampleConsensusModelPlanemust be hidden. The implementations ofdist8anddist4are moved from sac_model_plane.hpp to sac_model_plane.h so that they are available whenSampleConsensusModelNormalPlaneis instantiated and the compiler can optimize.Split off from #5779