Updates to CXX flags and removal of cmake checks less than 3.16. #6144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larshg
changed the title
Disable Global optimization if CUDA is version 10 or 11 as they seems to be failing with their thrust version Update how CMAKE_CXX_FLAGS_DEFAULT is set as windows default values has changed.
mvieth
reviewed
Oct 4, 2024
|
I think it already possible to change CMAKE_MSVC_CODE_LINK_OPTIMIZATION - though I don't know how. But it wasn't my intention to make PCL_USE_GLOBAL_OPTIMIZATION changeable from user side. |
CMAKE_MSVC_CODE_LINK_OPTIMIZATION is already an cmake option that we provide 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move check for cuda up to be able to use CUDA_VERSION_STRING.
Disable Global optimization if CUDA is version 10 or 11 as they seems to be failing with their thrust version
Update how CMAKE_CXX_FLAGS_DEFAULT is set as windows default values has changed.