Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add & fix various incorrect or missing sprites #156

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

rayusagi
Copy link

@rayusagi rayusagi commented Nov 1, 2024

  • added missing Pikachu Word Cap front/back sprites

  • added missing female Eevee front/back/shiny sprites

  • added missing Spiky-Eared Pichu front sprite

  • changed Torchic female front sprites (default and shiny)
    The existing ones were not consistent with the general B/W style. The back sprites were already in that B/W style but the front ones were not. Since there is no visible difference between the two on the frontside (the actual difference is an extra pixel on the rear of the male), the same sprites as the male were used.

  • changed Buizel and Floatzel female front sprites (default and shiny)
    The exact same reason as Torchic. And just like Torchic, no difference is visible on the frontside so the same sprites as the male were used.

  • added missing Meowstic female front/back/shiny sprites
    Female Meowstic has a distinct pokémon ID in the API (10025) that didn't have sprites for the default backside and both shiny sides.

  • added missing Indeedee female front/back/shiny sprites
    Female Indeedee has a distinct pokémon ID in the API (10186) that didn't have sprites for the default backside and both shiny sides.

- added missing Pikachu Word Cap front/back sprites
- added missing female Eevee front/back/shiny sprites
- added missing Spiky-Eared Pichu front sprite
- changed Torchic female front sprites
- changed Buizel and Floatzel female front sprites
- added missing Meowstic female front/back sprites
- added missing Indeedee female front/back sprites
@Naramsim Naramsim merged commit 8cf9139 into PokeAPI:master Nov 8, 2024
@rayusagi
Copy link
Author

rayusagi commented Nov 8, 2024

Thanks!
However, for the new sprites I cannot witness the change in the API.
E.g. Pikachu World Cap :

"sprites": {
        "back_default": null,
        "back_female": null,
        "back_shiny": null,
        "back_shiny_female": null,
        "front_default": null,
        "front_female": null,
        "front_shiny": null,
        "front_shiny_female": null,
...
}

What needs to be done for it to appear there?
When I worked in local, after I had rebuild the database I could see the change.
Is it not what has been done here PokeAPI/pokeapi#1158 (comment) recently?
I can see here that it has actually been edited like expected.
What am I missing?

@Naramsim
Copy link
Member

Naramsim commented Nov 9, 2024

Caching, tomorrow I'll purge

@Naramsim
Copy link
Member

Naramsim commented Nov 9, 2024

Ok, can you try now?

@rayusagi
Copy link
Author

rayusagi commented Nov 9, 2024

Nice, everything is working as expected now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants