Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor POIs so that Mobs can be displayed #131

Merged
merged 24 commits into from
Oct 19, 2016
Merged

Refactor POIs so that Mobs can be displayed #131

merged 24 commits into from
Oct 19, 2016

Commits on Oct 17, 2016

  1. Make mapPokePOI() a utility function instead of a static method

    @MajorBreakfast
    MajorBreakfast committed Oct 17, 2016
    Configuration menu
    Copy the full SHA
    055d9b2 View commit details
    Browse the repository at this point in the history

  2. Call constructor, remove unusual Object.create() usage

    @MajorBreakfast
    MajorBreakfast committed Oct 17, 2016
    Configuration menu
    Copy the full SHA
    d8772f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2016

  1. Add button to manually show mob card

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    fef4f67 View commit details
    Browse the repository at this point in the history

  2. Make poi-card compatible with sightings and mobs

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    b9f78ac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' of https://github.com/PokemonGoers/Catch-em-all … 

    …into mob-card
    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    798ae98 View commit details
    Browse the repository at this point in the history

  4. Rename PokePOI to POI

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    23b313f View commit details
    Browse the repository at this point in the history

  5. Rename PokeMob to Mob

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    0540a55 View commit details
    Browse the repository at this point in the history

  6. Rename PokePrediction to Prediction

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    4263399 View commit details
    Browse the repository at this point in the history

  7. Rename PokeSighting to Sighting

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    d112e48 View commit details
    Browse the repository at this point in the history

  8. Rename PokeGender to PokemonGender, PokeAttackCategory to PokemonAtta… 

    …ckCategory
    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    d86c856 View commit details
    Browse the repository at this point in the history

  9. Remove pokemon property from Sighting and Prediction

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    39c9960 View commit details
    Browse the repository at this point in the history

  10. Refactor POI and its subclasses

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    55ca79e View commit details
    Browse the repository at this point in the history

  11. Replace Object.assign

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    1dd9ada View commit details
    Browse the repository at this point in the history

  12. PokeMob logo

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    101f2d0 View commit details
    Browse the repository at this point in the history

  13. Refactor poi-card layout and integrate mobs

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    0e503a9 View commit details
    Browse the repository at this point in the history

  14. Artificial tweets

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    6688ee6 View commit details
    Browse the repository at this point in the history

  15. Make POI#type a value property

    @MajorBreakfast
    MajorBreakfast committed Oct 18, 2016
    Configuration menu
    Copy the full SHA
    84414db View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2016

  1. Make tweet count text plural only

    @MajorBreakfast
    MajorBreakfast committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    451ffa6 View commit details
    Browse the repository at this point in the history

  2. Use elvis operator

    @MajorBreakfast
    MajorBreakfast committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    94e5d7a View commit details
    Browse the repository at this point in the history

  3. Set Mob data from map data, refactor MobTweet type

    @MajorBreakfast
    MajorBreakfast committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    569202d View commit details
    Browse the repository at this point in the history

  4. Extract poiFromMapEventData() into a module

    @MajorBreakfast
    MajorBreakfast committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    73279c6 View commit details
    Browse the repository at this point in the history

  5. Show artifial mob button only in development mode

    @MajorBreakfast
    MajorBreakfast committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    ae01cc1 View commit details
    Browse the repository at this point in the history

  6. Use ngIf instead of hidden attribute

    @MajorBreakfast
    MajorBreakfast committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    6599949 View commit details
    Browse the repository at this point in the history

  7. get isDevelopEnvironment()

    @MajorBreakfast
    MajorBreakfast committed Oct 19, 2016
    Configuration menu
    Copy the full SHA
    f8ace07 View commit details
    Browse the repository at this point in the history