Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Data Sources Logic #60

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

maxachis
Copy link

@maxachis maxachis commented Jul 22, 2024

DEPENDS ON DATABASE CHANGES NOT YET INCORPORATED.

See PR: Police-Data-Accessibility-Project/prod-to-dev-migration#17

Fixes

Description

  • This commit includes updates to the database client module, such as the addition of parameter objects for agency data source queries, dynamic query construction based on parameters, and methods for fetching approved data sources, needs identification data sources, and data sources for mapping.
  • It also includes improvements to query construction for typeahead suggestions and search queries.

Testing

  • Run all tests in tests directory

Performance

  • Refactor. Performance impact marginal.
  • Likely additional overhead through utilizing a view.

Docs

  • Not applicable.

…he addition of parameter objects for agency data source queries, dynamic query construction based on parameters, and methods for fetching approved data sources, needs identification data sources, and data sources for mapping. It also includes improvements to query construction for typeahead suggestions and search queries.
@maxachis maxachis changed the title This commit includes updates to the database client module, such as t… Refactor Data Sources Logic Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant