Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add tertiary intent to Button #47

Merged
merged 3 commits into from
Jan 30, 2024

Conversation

joshuagraber
Copy link
Collaborator

@joshuagraber joshuagraber commented Jan 30, 2024

Addresses #43

note: I accidentally pushed this work directly to main after forgetting which branch I was on. It's reverted there, but the npm version will unfortunately be bumped twice for this work

To test

  1. Pull this PR and run npm link
  2. Check out data-sources at PR 198
  3. In data-sources/client, run npm link design-system
  4. Run the apps, ensure everything on the DataSourceStaticView component works as it currently does on data-sources.pdap.dev
  5. Cleanup: run npm unlink pdap-design-system and discard changes to package.json

@joshuagraber joshuagraber self-assigned this Jan 30, 2024
Copy link
Contributor

@josh-chamberlain josh-chamberlain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, is this for cases where a button just has some function in the UI and it's not part of a form or something? I did read the issue but I'm still not sure I understand

@joshuagraber
Copy link
Collaborator Author

so, is this for cases where a button just has some function in the UI and it's not part of a form or something?

@josh-chamberlain Yes, that's what I'm thinking. Currently most useful for the clickable pill-shaped buttons in the DataSourceStaticView page in data-sources.

@joshuagraber joshuagraber merged commit 51e21cd into main Jan 30, 2024
5 checks passed
@joshuagraber joshuagraber deleted the feature/tertiary-button branch January 30, 2024 18:40
Copy link

🎉 This PR is included in version 2.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants