Integrate JWT Auth into API #2086
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikesmit
force-pushed
the
2063_add_auth_to_api
branch
2 times, most recently
from
50cf3dd to
566e149
Compare
mikesmit
force-pushed
the
2063_add_auth_to_api
branch
2 times, most recently
from
361b3d4 to
371bb04
Compare
partially fixes #2063 This will allow us to add permissions checks to our API calls. Currently it does not require a valid JWT, but if one exists will store the "sub" field such that the user's id can be checked against our user table to establish permissions. In the user profile api calls we will check user permission, but not yet fail (just log) if the constraint is not met.
mikesmit
force-pushed
the
2063_add_auth_to_api
branch
from
371bb04 to
afe0a12
Compare
nikhilwoodruff
approved these changes
Jan 8, 2025
|
@mikesmit Looks like there's a merge conflict. Is it possible that you opened this branch off of another partly-implemented branch? If so, could you rebase off master and ensure that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes #2063
This will allow us to add permissions checks to our API calls. Currently
it does not require a valid JWT, but if one exists will store the "sub"
field such that the user's id can be checked against our user table to
establish permissions.
In the user profile api calls we will check user permission, but not yet
fail (just log) if the constraint is not met.