Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert error behaviour on combined adds/subtracts and formulas #156

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

nikhilwoodruff
Copy link
Contributor

Fixes #139

@nikhilwoodruff nikhilwoodruff self-assigned this Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a5fbf0) 82.55% compared to head (9ef83fa) 82.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   82.55%   82.55%   -0.01%     
==========================================
  Files         185      185              
  Lines        9000     8998       -2     
  Branches     1129     1128       -1     
==========================================
- Hits         7430     7428       -2     
  Misses       1301     1301              
  Partials      269      269              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikhilwoodruff nikhilwoodruff merged commit b8f1367 into master Feb 14, 2024
4 of 6 checks passed
@nikhilwoodruff nikhilwoodruff deleted the revert-adds-error-handling branch February 14, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assert that only one of a formula or adds/subtracts pairs defines a variable
1 participant