Add method for propagating units to descendants for ParameterScale objects
#162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 82.55% 82.59% +0.03%
==========================================
Files 185 186 +1
Lines 8998 9018 +20
Branches 1128 1134 +6
==========================================
+ Hits 7428 7448 +20
Misses 1301 1301
Partials 269 269 ☔ View full report in Codecov by Sentry. |
|
I am not sure why all commits in my handle_units branch don't appear in the pull request: Update: the commits appeared after I entered this comment |
nikhilwoodruff
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make format && make documentationhas been run.What's changed
ParameterScaleobjects... #161 by adding a method for propagating units declared in the metadata of aParameterScaleobject to the metadata of its descendants -- see the test files for an example.sphinx.