Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AMT #344

Merged
merged 11 commits into from
Dec 28, 2021
Merged

Add AMT #344

merged 11 commits into from
Dec 28, 2021

Conversation

nikhilwoodruff
Copy link
Collaborator

Adds parameters and variables from AMT in taxcalc.

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't dug into the logic yet

openfisca_us/variables/irs/outputs.py Outdated Show resolved Hide resolved
openfisca_us/variables/irs/outputs.py Outdated Show resolved Hide resolved
openfisca_us/variables/irs/outputs.py Show resolved Hide resolved
openfisca_us/parameters/irs/income/amt/brackets.yaml Outdated Show resolved Hide resolved
openfisca_us/variables/irs/inputs.py Show resolved Hide resolved
openfisca_us/variables/irs/outputs.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #344 (a56874a) into master (7fecba6) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
+ Coverage   94.51%   94.67%   +0.15%     
==========================================
  Files          59       59              
  Lines        3428     3510      +82     
  Branches      469      473       +4     
==========================================
+ Hits         3240     3323      +83     
+ Misses        163      162       -1     
  Partials       25       25              
Impacted Files Coverage Δ
openfisca_us/variables/irs/inputs.py 99.63% <100.00%> (+0.13%) ⬆️
openfisca_us/variables/irs/outputs.py 97.65% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fecba6...a56874a. Read the comment docs.

@nikhilwoodruff
Copy link
Collaborator Author

@MaxGhenis - so it turns out the OpenFisca logic was correct here: because the calcfunctions in taxcalc are not independent of each other, my approach of generating a unit test by feeding the relevant final variables into the function was incorrect. I've added the script generating unit tests, plus ten random (from the CPS, with non-zero outputs) unit tests for AMT.

@nikhilwoodruff nikhilwoodruff merged commit a5bb574 into master Dec 28, 2021
@nikhilwoodruff nikhilwoodruff linked an issue Dec 28, 2021 that may be closed by this pull request
@MaxGhenis MaxGhenis deleted the amt branch January 30, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AMT
2 participants