-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMT #344
Add AMT #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't dug into the logic yet
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 94.51% 94.67% +0.15%
==========================================
Files 59 59
Lines 3428 3510 +82
Branches 469 473 +4
==========================================
+ Hits 3240 3323 +83
+ Misses 163 162 -1
Partials 25 25
Continue to review full report at Codecov.
|
@MaxGhenis - so it turns out the OpenFisca logic was correct here: because the calcfunctions in taxcalc are not independent of each other, my approach of generating a unit test by feeding the relevant final variables into the function was incorrect. I've added the script generating unit tests, plus ten random (from the CPS, with non-zero outputs) unit tests for AMT. |
Adds parameters and variables from
AMT
intaxcalc
.