Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the required doctrine/common #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BallisticPain
Copy link

Testing this now. Not sure why a max doctrine/common version is even being specified.

Testing this now. Not sure why a max doctrine/common version is even being specified.
@BallisticPain
Copy link
Author

So testing didn't work as expected (as to the composer.json). I am testing this version of PSSDoctrineExtensionsBundle with the version of Doctrine/Common that's coming with sf2.1.x.

@TomAdam
Copy link
Contributor

TomAdam commented Dec 18, 2012

The doctrine/common max version is specified to prevent any future BC breaks in doctrine causing compatibility problems. At the point the composer file was created doctrine had not yet released 2.3. If you have tested the bundle is working as expected with 2.3 then upping the compatible version as you have done in your PR is definitely the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants