-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GKR2 verifier + SIMD for prover #139
Open
enpsi20481
wants to merge
8
commits into
PolyhedraZK:dev
Choose a base branch
from
enpsi20481:gkr2-verifier
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
enpsi20481
commented
Nov 5, 2024
•
edited
Loading
edited
- GKR2 Verifier
- test for circuit with public inputs
- SIMD support in GKR2 prover
- MPI support in GKR2 prover
enpsi20481
force-pushed
the
gkr2-verifier
branch
3 times, most recently
from
November 6, 2024 13:37
362916b
to
ef4a9fe
Compare
enpsi20481
changed the title
feat: SIMD support for GKR2 prover
feat: GKR2 verifier + SIMD for prover
Nov 6, 2024
enpsi20481
commented
Nov 15, 2024
@@ -143,6 +146,45 @@ impl<C: GKRConfig> VerifierScratchPad<C> { | |||
deg3_lag_denoms_inv[i] = denominator.inv().unwrap(); | |||
} | |||
|
|||
let deg6_eval_at = if C::FIELD_TYPE == FieldType::GF2 { | |||
// TODO: Does this correctly define Lagrange poly for GF2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhenfeizhang tbh I'm unsure how to construct Lagrange polynomials over a binary field, please advise.
enpsi20481
force-pushed
the
gkr2-verifier
branch
from
November 15, 2024 15:58
312bf72
to
7a524b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.