Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features: Orion implementation related peripheral building blocks #142

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Features: Orion implementation related peripheral building blocks #142

merged 6 commits into from
Nov 12, 2024

Conversation

tonyfloatersu
Copy link
Contributor

This PR contains following things in favor of Orion pcs implementation in #137:

  • A GF2x64 SimdField implementation over u64.
  • A SimdField implementation for in GF2_128 for GF2 elements.
  • Refactoring pack_size() method in SimdField into trait constant PACK_SIZE: usize.
  • A bug fix for a faulty FIELD_SIZE in NeonGF2_128x8.
  • Clonable Fiat-Shamir transcript, and challenge index into PCP oracle (credit to building blocks for basefold pcs #133).
  • Extending ExtensionField with Mul<Self::BaseField> in support of multiplication with base field elems (controversial, up for discussion).

This was referenced Nov 9, 2024
Merged
Open
zhiyong1997
zhiyong1997 requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@zhiyong1997 zhiyong1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As commented.

@tonyfloatersu tonyfloatersu merged commit 30c80f8 into dev Nov 12, 2024
28 checks passed
@tonyfloatersu tonyfloatersu deleted the hs/orion-building-blocks-arith branch November 12, 2024 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiyong1997 zhiyong1997 zhiyong1997 approved these changes

@zhenfeizhang zhenfeizhang Awaiting requested review from zhenfeizhang

@niconiconi niconiconi Awaiting requested review from niconiconi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyfloatersu @zhiyong1997