-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adapt allay update #484
base: ver/6.6.0
Are you sure you want to change the base?
Conversation
* feat: update mapping files to latest
platforms/allay/src/main/java/com/dfsek/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/com/dfsek/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/com/dfsek/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/com/dfsek/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
ah, you're not the person who originally added the allay platform, so those comments about instead deserializing using a bespoke object can be ignored. that would be for another PR or for a maintainer of the platform (eg. @smartcmd) to add tbh. |
it would be ideal if all the formatting changes could be reverted so that it's only code changes. |
Another thing is you have to pin a version of allay instead of rolling release |
yeah, I mentioned that in one of the comments |
I will create another branch for refactoring this code and accepting |
apply the |
Already |
It seems that all the problems have been solved, waiting for the response😄 |
Adapt Allay materials update and update to the latest minecraft version