Merge pull request #583 from PolymerElements/no-invalid-typedef

This code was using @typedef like @type, which is invalid
PolymerElements · Jan 21, 2020 · 5882cd2 · 5882cd2
2 parents 275c510 + 4e38e15
commit 5882cd2
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 24 deletions.
diff --git a/app-scroll-effects/effects/blend-background.js b/app-scroll-effects/effects/blend-background.js
@@ -48,10 +48,7 @@ registerEffect('blend-background', {
 class BlendBackground {
   constructor() {
     /**
-     * @typedef {{
-     *   backgroundFrontLayer: !HTMLElement,
-     *   backgroundRearLayer: !HTMLElement,
-     * }}
+     * @type {?}
      */
     this._fxBlendBackground;
   }

diff --git a/app-scroll-effects/effects/fade-background.js b/app-scroll-effects/effects/fade-background.js
@@ -57,10 +57,7 @@ registerEffect('fade-background', {
 class FadeBackground {
   constructor() {
     /**
-     * @typedef {{
-     *   backgroundFrontLayer: !HTMLElement,
-     *   backgroundRearLayer: !HTMLElement,
-     * }}
+     * @type {?}
      */
     this._fxFadeBackground;
   }

diff --git a/app-scroll-effects/effects/parallax-background.js b/app-scroll-effects/effects/parallax-background.js
@@ -69,11 +69,7 @@ class ParallaxBackground {
     this._dHeight;
 
     /**
-     * @typedef {{
-     *   background: !HTMLElement,
-     *   backgroundFrontLayer: !HTMLElement,
-     *   backgroundRearLayer: !HTMLElement,
-     * }}
+     * @type {?}
      */
     this._fxParallaxBackground;
   }

diff --git a/app-scroll-effects/effects/resize-snapped-title.js b/app-scroll-effects/effects/resize-snapped-title.js
@@ -70,10 +70,7 @@ registerEffect('resize-snapped-title', {
 class ResizeSnappedTitle {
   constructor() {
     /**
-     * @typedef {{
-     *   title: !HTMLElement,
-     *   condensedTitle: !HTMLElement,
-     * }}
+     * @type {?}
      */
     this._fxResizeSnappedTitle;
   }

diff --git a/app-scroll-effects/effects/resize-title.js b/app-scroll-effects/effects/resize-title.js
@@ -103,13 +103,7 @@ class ResizeTitle {
     this.condenses;
 
     /**
-     * @typedef {{
-     *   title: !HTMLElement,
-     *   condensedTitle: !HTMLElement,
-     *   scale: number,
-     *   titleDX: number,
-     *   titleDY: number,
-     * }}
+     * @@type {?}
      */
     this._fxResizeTitle;
   }