This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Define path and query param propagation semantics. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return; | ||
| } | ||
|
|
||
| this.set('route.__' + changes.path, changes.value); |
There was a problem hiding this comment.
will changes.path and changes.value exist even when the changes are splices? I guess we can probably ignore that case though, because we don't support arrays inside of queryParams currently
There was a problem hiding this comment.
We don't, but a derived element might. But, maybe we should table implementation until we have true inheritance. WDYT?
There was a problem hiding this comment.
Filed #42 so that we can fix later.
|
This looks really nice. Just a few comments. |
cdata
force-pushed
the
new-propagation-semantics
branch
from
b4cd935 to
34fcdb5
Compare
|
Filed PolymerElements/test-fixture#31 to address the |
|
LGTM! |
cdata
added a commit
that referenced
this pull request
Mar 17, 2016
Define path and query param propagation semantics.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38