Merge pull request #23 from PolymerElements/ignore-right-click-on-but…

…tons

Ignore non-primary mouse input.

iron-button-state.html

@@ -91,6 +91,8 @@
       'space:keyup': '_spaceKeyUpHandler',
     },
 
+    _mouseEventRe: /^mouse/,
+
     _tapHandler: function() {
       if (this.toggles) {
        // a tap is needed to toggle the active state
@@ -111,7 +113,33 @@
       this.fire('change');
     },
 
-    _downHandler: function() {
+    _eventSourceIsPrimaryInput: function(event) {
+      event = event.detail.sourceEvent || event;
+
+      // Always true for non-mouse events....
+      if (!this._mouseEventRe.test(event.type)) {
+        return true;
+      }
+
+      // http://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/buttons
+      if ('buttons' in event) {
+        return event.buttons === 1;
+      }
+
+      // http://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/which
+      if (typeof event.which === 'number') {
+        return event.which < 2;
+      }
+
+      // http://developer.mozilla.org/en-US/docs/Web/API/MouseEvent/button
+      return event.button < 1;
+    },
+
+    _downHandler: function(event) {
+      if (!this._eventSourceIsPrimaryInput(event)) {
+        return;
+      }
+
       this._setPointerDown(true);
       this._setPressed(true);
       this._setReceivedFocusFromKeyboard(false);

test/active-state.html

@@ -41,6 +41,15 @@
         activeTarget = fixture('TrivialActiveState');
       });
 
+      suite('non-primary pointer input source', function() {
+        test('does not cause state to change', function() {
+          var rightClickMouseEvent = new CustomEvent('mousedown');
+          rightClickMouseEvent.buttons = 2;
+          activeTarget.dispatchEvent(rightClickMouseEvent);
+          expect(activeTarget.pressed).to.be.equal(false);
+        });
+      });
+
       suite('active state with toggles attribute', function() {
         setup(function() {
           activeTarget = fixture('ToggleActiveState');