Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #153 #154

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes issue #153 #154

wants to merge 1 commit into from

Conversation

ccjmne
Copy link

@ccjmne ccjmne commented Nov 6, 2016

Fixes issue #153 by creating a stacking context on the [main] content so that all its potentially z-indexed children are stacked within a context scoped to that element.

Introduced as little change as possible

The #scrim overlay sits over it simply by being added next -- current behavior inchanged.
Stacking context created with:

will-change: transform;

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@ccjmne
Copy link
Author

ccjmne commented Nov 6, 2016

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants