Skip to content
This repository has been archived by the owner on Dec 19, 2024. It is now read-only.

Fix animation end callback in manual mode #143

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jtagscherer
Copy link

Fixes #132.

Previously, switching to manual mode would, among other listeners, deregister the animationend listener. Therefore, after an animation that had been manually started by the user had finished, the necessary callback would not be executed. The _animationPlaying flag would not be set to false after playback, causing subsequent animations to be cancelled. This pull request fixes this issue by keeping this necessary callback active for the whole lifecycle of the paper-tooltip.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When manual mode is true _animationPlaying is never set to false
2 participants