Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some configurations break dom-template #31

Open
cdata opened this issue Mar 16, 2016 · 1 comment
Open

Some configurations break dom-template #31

cdata opened this issue Mar 16, 2016 · 1 comment

Comments

@cdata
Copy link
Contributor

cdata commented Mar 16, 2016

It is possible for some configurations of elements to break when using dom-template to stamp some DOM. dom-template attempts to notify the "parent" context of property changes, and ends up effectively trying if(foo in undefined) { ... }, which throws.

@parioux
Copy link

parioux commented Jun 17, 2016

Had the same problem while writing a test ...
Got around it by setting the _parentProps property to an empty object (crashes in notifyPath function).
Found the workaround by looking at the commits of app-route mentioned here.

var tmpl = document.querySelector('#my-test-fixture').fixtureTemplates[0];
tmpl._parentProps = {};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants