Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incremental backups #72

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: incremental backups #72

merged 1 commit into from
Jul 3, 2024

Conversation

Daesgar
Copy link
Contributor

@Daesgar Daesgar commented Jul 3, 2024

Incremental backups were not working because, for some reason (maybe a bug or something I don't understand at all), the base_backup setting was not correctly set using the clickhouse-driver library settings parameter.

To solve that, instead of relying on the settings parameter on query execution, we put the settings directly in the query and replace them accordingly.

Finally, the last_base_backup was not being updated for incremental backups, so they were always using the same one, instead of the previous incremental one.

image

Restore worked fine as well:

image

@Daesgar Daesgar requested a review from fuziontech July 3, 2024 11:36
Copy link
Member

@fuziontech fuziontech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 it

@Daesgar Daesgar merged commit 6bab56f into main Jul 3, 2024
2 checks passed
@Daesgar Daesgar deleted the fix-incremental-backups branch July 3, 2024 14:07
Copy link

sentry-io bot commented Jul 8, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ NetworkError: Connection refused (127.0.0.1:9000) housewatch.celery.run_backup View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants